Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🩹 Handle missing SVD attributes #45

Merged
merged 2 commits into from
Dec 9, 2021
Merged

🩹 Handle missing SVD attributes #45

merged 2 commits into from
Dec 9, 2021

Conversation

s-weigand
Copy link
Member

@s-weigand s-weigand commented Nov 13, 2021 •
edited
Loading

Handle missing SVD by computing them if they are missing in plots that use them.

We still need to add some unit testing for this, but first we need to have a look at how to properly test plots 😅

Change summary

Checklist

  • ✔️ Passing the tests (mandatory for all PR's)

Closes issues

closes #16

@s-weigand s-weigand requested a review from a team as a code owner November 13, 2021 22:22
@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch s-weigand/pyglotaran-extras/handle-missing-svd

@codecov
Copy link

codecov bot commented Nov 13, 2021 •
edited
Loading

Codecov Report

Merging #45 (cf036b7) into main (619bce0) will decrease coverage by 0.14%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   40.93%   40.78%   -0.15%     
==========================================
  Files          22       22              
  Lines         601      608       +7     
  Branches       77       78       +1     
==========================================
+ Hits          246      248       +2     
- Misses        355      360       +5
Impacted Files Coverage Δ
pyglotaran_extras/plotting/plot_svd.py 20.00% <20.00%> (ø)
pyglotaran_extras/plotting/plot_data.py 40.00% <50.00%> (+0.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 619bce0...cf036b7. Read the comment docs.

jsnel
jsnel approved these changes Nov 13, 2021
View reviewed changes
Copy link
Member

@jsnel jsnel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine. Perhaps an idea to move the method out of glotaran.io at some point, to a utility module or maybe even make it local to -extras.

@s-weigand s-weigand merged commit 01ab372 into glotaran:main Dec 9, 2021
@s-weigand s-weigand deleted the handle-missing-svd branch December 9, 2021 17:11
@s-weigand
Copy link
Member Author

Seems fine. Perhaps an idea to move the method out of glotaran.io at some point, to a utility module or maybe even make it local to -extras.

Yeah, I would basically move the content of the whole glotaran.io.prepare_dataset module to glotaran.utils.io.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsnel jsnel jsnel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Handle missing SVD attributes
2 participants
@s-weigand @jsnel